fix(gmail): stop hard-wrapping plain text email bodies at ~72 chars#476
Merged
steipete merged 1 commit intoopenclaw:mainfrom Apr 20, 2026
Merged
Conversation
…event hard-wrapping Plain text email bodies were encoded with Content-Transfer-Encoding: 7bit, which meant long lines (>78 chars) violated RFC 5322 line length limits. Gmail's SMTP transport would then hard-wrap lines at ~72 characters, inserting literal CRLF breaks mid-paragraph and destroying formatting. Switch text/plain parts to quoted-printable encoding. The QP encoder inserts soft line breaks (=CRLF) that recipients' mail clients strip, preserving the original paragraph structure. HTML bodies remain 7bit since HTML rendering is unaffected by line breaks. Fixes openclaw#475
Collaborator
|
Landed on main.
Thanks @shashankkr9! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
gog gmail send --body/--body-filewere hard-wrapped at ~72 characters, destroying paragraph formattingtext/plainMIME parts usedContent-Transfer-Encoding: 7bit, so long lines violated RFC 5322 limits and Gmail's SMTP transport hard-wrapped themtext/plainparts toquoted-printableencoding — the QP encoder inserts soft line breaks (=\r\n) that mail clients strip, preserving original paragraph structure7bit(unaffected since HTML ignores whitespace)Changes
internal/cmd/gmail_mime.go— usemime/quotedprintable.Writerfor all plain text body paths (standalone, multipart/alternative, multipart/mixed)internal/cmd/gmail_mime_test.go— 3 new tests: long line QP round-trip, multi-paragraph round-trip, HTML stays 7bitTest plan
go test ./...)go vet ./...clean🤖 Generated with Claude Code