Skip to content

feat(secrets): allow overriding keyring service name#463

Closed
mkurz wants to merge 1 commit intoopenclaw:mainfrom
mkurz:feat/keyring-service-name-env
Closed

feat(secrets): allow overriding keyring service name#463
mkurz wants to merge 1 commit intoopenclaw:mainfrom
mkurz:feat/keyring-service-name-env

Conversation

@mkurz
Copy link
Copy Markdown
Contributor

@mkurz mkurz commented Mar 19, 2026

Summary

Add GOG_KEYRING_SERVICE_NAME as an environment variable override for the keyring ServiceName.

This keeps the default behavior unchanged (gogcli), but allows Linux/KWallet users to point gog at a different wallet/collection name when needed, for example:

export GOG_KEYRING_SERVICE_NAME=kdewallet

Changes

  • add GOG_KEYRING_SERVICE_NAME support in internal/secrets/store.go
  • keep the default service name as gogcli when the env var is unset
  • add tests covering the default and override behavior
  • document the new env var in README.md and docs/spec.md

Test plan

  • GOCACHE=/tmp/go-build go test ./internal/secrets

User-facing changes

  • new env var: GOG_KEYRING_SERVICE_NAME
  • no behavior change unless the env var is set

@steipete
Copy link
Copy Markdown
Collaborator

Thanks! Landed manually on main as c4665c4, with a follow-up lint cleanup in a8531f2, plus tests/docs/CHANGELOG and co-author trailer. Closing this PR since the keyring service-name override is now on main.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants