fix(drive,gmail): pass-through filter queries and encode non-ASCII headers#260
Closed
salmonumbrella wants to merge 1 commit intoopenclaw:mainfrom
Closed
fix(drive,gmail): pass-through filter queries and encode non-ASCII headers#260salmonumbrella wants to merge 1 commit intoopenclaw:mainfrom
salmonumbrella wants to merge 1 commit intoopenclaw:mainfrom
Conversation
…aders Drive search now detects raw API filter syntax (field comparisons, contains, membership, has) and passes it through instead of wrapping in fullText contains. Plain-text searches always append trashed=false to prevent false positives. Gmail MIME now RFC 2047-encodes display names with non-ASCII characters in From/To/Cc/Bcc/Reply-To headers using net/mail. Fixes openclaw#254, fixes openclaw#255 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Collaborator
|
Landed via #266 (had to resolve cross-repo conflicts). Thanks @salmonumbrella. |
This was referenced Mar 2, 2026
7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
contains,inmembership,hasproperty,sharedWithMe) and passes it through verbatim instead of wrapping infullText contains. Plain-text searches always appendtrashed = falseto prevent false positives when the search term contains the word "trashed".From/To/Cc/Bcc/Reply-Toheaders usingnet/mail, fixing garbled headers.Fixes #254, fixes #255
Test plan
buildDriveSearchQuery(plain text, filter pass-through, trashed already present, plain text containing "trashed")looksLikeDriveFilterQuery(28 cases: filter syntax + natural language)formatAddressHeader(UTF-8 display name, plain address, unparseable fallback)formatAddressHeaders(mixed addresses, empty value filtering)go test ./...)🤖 Generated with Claude Code