fix(keychain): show "gogcli" in security prompty instead of "" empty string#106
Closed
maxceem wants to merge 1 commit intoopenclaw:mainfrom
Closed
fix(keychain): show "gogcli" in security prompty instead of "" empty string#106maxceem wants to merge 1 commit intoopenclaw:mainfrom
maxceem wants to merge 1 commit intoopenclaw:mainfrom
Conversation
macOS keychain dialogs showed an empty item label on access. Set the keychain item label to "gogcli" so the prompt is clear.
|
I am experiencing the same issue, it is not a big problem, but for first-time users of gog/Open Claw it is very sus to see an empty string in an authorization alert. Might scare them off like it nearly did for me 😅 |
Collaborator
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
macOS keychain prompts showed an empty item label ("") when gog accessed stored tokens, which looked suspicious for me as a user:
Solution
Set the keychain item label to "gogcli" (
config.appName) for all keyring writes so the prompt is clear and looks safe.Test
Tested locally.
NOTE: the fix would only work for newly created records in Keychain.
gog auth remove <email>gog auth add <email>gog auth listgog wants to use your confidential information stored in "gogcli" in your keychain.with "gogcli" instead of "".