Skip to content

fix: Windows test failures in keyring, config, secrets, and path expansion #395

@visionik

Description

@visionik

Summary

9 tests are currently skipped on Windows CI (added in #388) because the underlying code assumes macOS/Linux:

Keyring / Auth (3 tests)

  • TestAuthAddCmd_JSON
  • TestAuthListRemoveTokensListDelete_JSON
  • TestAuthServicesCmd_JSON

These fail because the keyring backend expects macOS Keychain or Linux keyring. Windows Credential Manager support is needed.

Config / Credentials (3 tests)

  • TestListClientCredentials
  • TestConfigExists
  • TestReadClientCredentials_Errors

Fail due to config path or environment variable assumptions that don't hold on Windows.

Path Expansion (1 test)

  • TestExpandPath (subtests: tilde_only, tilde_with_subpath)

~ expansion uses $HOME which isn't set by default on Windows (should fall back to $USERPROFILE).

Secrets (1 test)

  • TestResolveKeyringBackendInfo_Default — expects auto backend, gets file on Windows.

Tracking (1 test)

  • TestLoadSecrets_LegacyFallback — legacy secret path resolution differs on Windows.

Acceptance Criteria

  • All 9 tests pass on windows-latest in CI
  • Remove the -skip list from the windows job in .github/workflows/ci.yml
  • No regressions on Linux or macOS

References

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type
    No fields configured for issues without a type.

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions