fix: clarify managed Windows provider boundary#21
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
windowsMode=normal, with explicit WSL2/static-host guidancestatus/inspectdisplay the lease target from the broker so AWS Windows leases do not render as local default Linuxprovider=sshfor existing non-Linux hostscc @steipete
Live AWS proof
crabbox run --provider aws --target windows --market on-demand --idle-timeout 15m --timing-json --shell 'Write-Output ("OS=" + (Get-CimInstance Win32_OperatingSystem).Caption); git --version; (tar --version | Select-Object -First 1); Write-Output "CRABBOX_WINDOWS_OK=1"'cbx_56052950ae48/blue-crab; requestedc7a.48xlarge, fell back after quota tom7i.4xlargeOS=Microsoft Windows Server 2022 Datacenter,git version 2.52.0.windows.1,bsdtar 3.8.4,CRABBOX_WINDOWS_OK=112.737s, command4.361s, total20.546s, exit0cbx_56052950ae48 ... state=releasedValidation
go test ./internal/cli -run 'TestValidateProviderTarget|TestLeaseStatusRequiresSSHReadiness|TestVersion'go test ./...go vet ./...npm run format:check --prefix workernpm run lint --prefix workernpm run check --prefix workernpm test --prefix workernpm run build --prefix workergit diff --checkCRABBOX_COORDINATOR= CRABBOX_PROVIDER=hetzner CRABBOX_TARGET=windows CRABBOX_WINDOWS_MODE=normal go run ./cmd/crabbox warmupCRABBOX_COORDINATOR= CRABBOX_PROVIDER=aws CRABBOX_TARGET=windows CRABBOX_WINDOWS_MODE=wsl2 go run ./cmd/crabbox warmup