Skip to content

fix(aws): configure Windows SSH ports#18

Merged
vincentkoc merged 1 commit into
mainfrom
fix/windows-targets
May 4, 2026
Merged

fix(aws): configure Windows SSH ports#18
vincentkoc merged 1 commit into
mainfrom
fix/windows-targets

Conversation

@vincentkoc

Copy link
Copy Markdown
Member

Summary

  • configure AWS Windows OpenSSH to listen on Crabbox's configured SSH port plus fallback ports
  • open matching Windows Firewall rules during desktop bootstrap
  • preserve the discovered SSH port across AWS Windows bootstrap waits

cc @steipete

Notes

  • Hetzner Windows is still intentionally unsupported in this provider path; the CLI fails before provisioning with provider=hetzner currently supports target=linux only; use provider=ssh for target=windows.

Verification

  • go test ./internal/cli -run 'TestAWSUserDataWindowsProfile|TestAWSUserDataMacOSProfile|TestCloudInitUsesRetryingBootstrap|TestSSHPortCandidates'
  • npm run format:check --prefix worker
  • npm run lint --prefix worker
  • npm run check --prefix worker
  • npm test --prefix worker -- bootstrap.test.ts config.test.ts

Known local noise

  • go test ./internal/cli hit existing flaky TestRunEventStreamWriterCapsOutputEvents: outputBytes=28672, want 65536.

@vincentkoc vincentkoc marked this pull request as ready for review May 4, 2026 06:27
@vincentkoc vincentkoc merged commit 8c6512e into main May 4, 2026
4 checks passed
@vincentkoc vincentkoc deleted the fix/windows-targets branch May 4, 2026 06:27
@jwmoss jwmoss mentioned this pull request May 7, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant