Revert change made to contact from address#8931
Merged
danielkerr merged 1 commit intoopencart:3.0.x.x_Maintenancefrom May 29, 2022
Merged
Revert change made to contact from address#8931danielkerr merged 1 commit intoopencart:3.0.x.x_Maintenancefrom
danielkerr merged 1 commit intoopencart:3.0.x.x_Maintenancefrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The from address can't be the customers address. If the customer has DMARC (using SPF & DKIM) correctly set up on their domain, then the email could likely be rejected by the store owners mail server.
Setting the from address as the customers email address was a workaround for some buggy Microsoft email clients that ignored the reply-to address.