apcu: store native PHP values — remove manual serialize()/unserialize()#15204
Merged
mhcwebdesign merged 2 commits intoopencart:3.0.x.xfrom Nov 15, 2025
Merged
apcu: store native PHP values — remove manual serialize()/unserialize()#15204mhcwebdesign merged 2 commits intoopencart:3.0.x.xfrom
mhcwebdesign merged 2 commits intoopencart:3.0.x.xfrom
Conversation
This change removes explicit serialize() on set() and explicit unserialize() on get() and stores values directly with apcu_store() / apcu_fetch() (native PHP zvals). APCu cache driver: store native PHP values instead of manual serialization — improved performance and memory usage; backward-compatible with existing cached entries.
This change removes explicit serialize() on set() and explicit unserialize() on get() and stores values directly with apcu_store() / apcu_fetch() (native PHP zvals). APCu cache driver: store native PHP values instead of manual serialization — improved performance and memory usage; backward-compatible with existing cached entries.
Contributor
|
I have now merged it to the 3.0.x.x branch, thanks for this update. For the future: Please make sure to use leading tabs instead of leading spaces for the indentations in PHP files, see e.g. #15205 and https://github.com/opencart/opencart/wiki/Coding-standards#indentation . |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change removes explicit serialize() on set() and explicit unserialize() on get() and stores values directly with apcu_store() / apcu_fetch() (native PHP zvals).
APCu cache driver: store native PHP values instead of manual serialization — improved performance and memory usage; backward-compatible with existing cached entries.