Skip to content

Update IfNode.php [php 8.4.x compatibility]#14928

Merged
danielkerr merged 1 commit intoopencart:3.0.x.xfrom
osworx:3.0.x.x
Jun 10, 2025
Merged

Update IfNode.php [php 8.4.x compatibility]#14928
danielkerr merged 1 commit intoopencart:3.0.x.xfrom
osworx:3.0.x.x

Conversation

@osworx
Copy link
Copy Markdown
Contributor

@osworx osworx commented Jun 9, 2025

No description provided.

@mhcwebdesign
Copy link
Copy Markdown
Contributor

Your suggested updates appear to be mainly for the 3rd party vendor libraries, such as twig, etc, used by OpenCart. I assume that these libraries already have been updated in their respective 3rd party sources, and we should use composer for an appropriate update in one go, rather than manually patching up these files.

Therefore the opencart/composer.json ( https://github.com/opencart/opencart/blob/3.0.x.x/composer.json ) should be updated to support PHP 8.4. We might loose support of PHP 7.3 or 7.4, but this is a mall sacrifice to make.

Use PHP 8.0, run composer for this opencart/composer.json, and hopefully it will support all of the PHP 8.x versions, including 8.4.

@ADDCreative
Copy link
Copy Markdown
Contributor

Looks like Twig need updating to 3.9 minimum for PHP 8.4 support. Twig 3.12 drops support for PHP 7. Twig 3.20 drops support for PHP 8.0.

@mhcwebdesign
Copy link
Copy Markdown
Contributor

Looks like Twig need updating to 3.9 minimum for PHP 8.4 support. Twig 3.12 drops support for PHP 7. Twig 3.20 drops support for PHP 8.0.

It currently uses Twig 3.8.0, so it makes sense to upgrade that one 3.9, via composer, if that's what's needed. When I have some time I'll look into it.

@osworx
Copy link
Copy Markdown
Contributor Author

osworx commented Jun 9, 2025

Everything you think to make it php 8.4.x compatible is okay.
Losing support for php 7.x is the smaller issue on it - or do you want to keep support for php 7.x?

@danielkerr danielkerr merged commit 7793f94 into opencart:3.0.x.x Jun 10, 2025
6 checks passed
@osworx osworx deleted the 3.0.x.x branch June 10, 2025 13:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants