$data['stores'] and $price are intentionally repeated rather than using +=.

It does follow the same style, the same code style is applied everywhere by php-cs-fixer this isn't manual edits.

It does follow the same style, the same code style is applied everywhere by php-cs-fixer this isn't manual edits.

I wasn't implying it was manual editing. You may have followed the changes with cs-fxer but what I mentioned above is that $data['stores'] and $price are intentionally repeated with the affected variable.

I was replying to the part you now deleted:

As for system/vendor.php file, the modifications suggests to use new blank lines between IF and foreach statements which doesn't follow the same direction as the core.

I was replying to the part you now deleted:

As for system/vendor.php file, the modifications suggests to use new blank lines between IF and foreach statements which doesn't follow the same direction as the core.

Ok, no problem.

$data['stores'] and $price are intentionally repeated rather than using +=.

Where was/when this decided, why have it different then every where else?

$data['stores'] and $price are intentionally repeated rather than using +=.

Where was/when this decided, why have it different then every where else?

I think this was decided before the re-integration of OCMod but I am not entirely sure if repetitive variables can be used as opposed to cs-fixer suggests, since. It was decided before, however, which is why I tend to keep that line clean from the change, until now.

It was added here: 975073a
It doesn't appear that there is any particular reason, just a human habit. Don't say that it's intentional if you don't actually know.

It was added here: 975073a It doesn't appear that there is any particular reason, just a human habit. Don't say that it's intentional if you don't actually know.

Well, according to these changes, it looks pretty much to me those were intented changes.