Skip to content

Update general.php#14523

Merged
danielkerr merged 1 commit intoopencart:masterfrom
TheCartpenter:patch-5
Feb 23, 2025
Merged

Update general.php#14523
danielkerr merged 1 commit intoopencart:masterfrom
TheCartpenter:patch-5

Conversation

@TheCartpenter
Copy link
Copy Markdown
Contributor

No description provided.

@osworx
Copy link
Copy Markdown
Contributor

osworx commented Feb 22, 2025

I really like the way how your are creating pull requests!
It's easy at a glance to see what's the reason for the request 👎

Is it too much to write just one (1) line why your creating all those?

@mhcwebdesign
Copy link
Copy Markdown
Contributor

mhcwebdesign commented Feb 22, 2025

It looks like he is using the phpdoc tool, or something similar.

In most cases, it doesn't add any useful details, because the function argument types are already specified.

Also, there would be no need to run it daily. Once a new OC version is about to be released, phpdoc could be run once for all php files.

The focus should be on genuine bugfixes.

@batumibiz
Copy link
Copy Markdown
Contributor

batumibiz commented Feb 22, 2025

This is an absolutely useless commit.
Functions have strict type casting.
Therefore, phpdoc does not carry any useful information and is an unnecessary clutter of the source code.

@TheCartpenter
Copy link
Copy Markdown
Contributor Author

TheCartpenter commented Feb 22, 2025

I really like the way how your are creating pull requests! It's easy at a glance to see what's the reason for the request 👎

Is it too much to write just one (1) line why your creating all those?

Simple. It is for the same reason as these kinds of posts where nobody ever complained about when it's somebody else doing it and nowhere to be near why should those complaints be posted here either:

@batumibiz
Copy link
Copy Markdown
Contributor

batumibiz commented Feb 22, 2025

Simple. It is for the same reason as these kinds of posts where nobody ever complained about when it's somebody else doing it and nowhere to be near why should those complaints be posted here either:

You give incorrect examples.
In them, the executable code itself changes slightly. You have an absolutely useless phpdoc in this commit, which does not affect in any way at all.

And of course, all the 4 PRs that you have just sent could have been done in 1 PR and with one commit, so as not to litter the story.

@TheCartpenter
Copy link
Copy Markdown
Contributor Author

Simple. It is for the same reason as these kinds of posts where nobody ever complained about when it's somebody else doing it and nowhere to be near why should those complaints be posted here either:

You give incorrect examples. In them, the executable code itself changes slightly. You have an absolutely useless phpdoc in this commit, which does not affect in any way at all.

And of course, all the 4 PRs that you have just sent could have been done in 1 PR and with one commit, so as not to litter the story.

That wasn't your original question. What you've asked is if it would be too much to write just one (1) line why I am creating all those and I answered the question accordingly.

@osworx
Copy link
Copy Markdown
Contributor

osworx commented Feb 22, 2025

Simple. It is for the same reason as these kinds of posts where nobody ever complained about when it's somebody else doing it and nowhere to be near why should those complaints be posted here either:

  • .. and so on ..

You give incorrect examples. In them, the executable code itself changes slightly. You have an absolutely useless phpdoc in this commit, which does not affect in any way at all.
And of course, all the 4 PRs that you have just sent could have been done in 1 PR and with one commit, so as not to litter the story.

That wasn't your original question. What you've asked is if it would be too much to write just one (1) line why I am creating all those and I answered the question accordingly.

False, it was me who asked.
And to add one more comment from me: it's boring to see what you are trying to do.
The difference between yours and many others requests is, they have some benefit and are usually usefull.
While yours could be done in one (1) pull request (as so many times here stated by different other users) you are filling my (and many others) mail inbox full of waste.

Why can't you focus on really important things and eleminate real bugs, or suggest usefull changes?

@TheCartpenter
Copy link
Copy Markdown
Contributor Author

Simple. It is for the same reason as these kinds of posts where nobody ever complained about when it's somebody else doing it and nowhere to be near why should those complaints be posted here either:

  • .. and so on ..

You give incorrect examples. In them, the executable code itself changes slightly. You have an absolutely useless phpdoc in this commit, which does not affect in any way at all.
And of course, all the 4 PRs that you have just sent could have been done in 1 PR and with one commit, so as not to litter the story.

That wasn't your original question. What you've asked is if it would be too much to write just one (1) line why I am creating all those and I answered the question accordingly.

False, it was me who asked. And to add one more comment from me: it's boring to see what you are trying to do. The difference between yours and many others requests is, they have some benefit and are usually usefull. While yours could be done in one (1) pull request (as so many times here stated by different other users) you are filling my (and many others) mail inbox full of waste.

Why can't you focus on really important things and eleminate real bugs, or suggest usefull changes?

Because, these changes are still useful and, as much as I recall, I don't go to people's posting and provid the thumbs down the way you do. Rather, I dedicate my time to support the community with the changes where this project has been originally going rather than poisining the pull requests with toxic comments. You don't like the way I post, then you're simply gonna have to live with it pell since nobody asked you. I am focusing on finishing the PHPDocs to improve the quality of the platform while the core is being developed and maintained on this repository, since people are looking forward to have a stable version of the next release, and that includes producing a documentation for it.

You don't like it? Then, you're not helping, it's people like you who encourage other people to bring down this community rather than helping it. Besides, I don't see much of your PRs on this repository as much as other users are contributing already. Therefore, you don't have a say so just leave the people alone. It's intoxicating what you're doing!

@batumibiz
Copy link
Copy Markdown
Contributor

batumibiz commented Feb 22, 2025

I am focusing on finishing the PHPDocs to improve the quality of the platform while the core is being developed and maintained on this repository, since people are looking forward to have a stable version of the next release, and that includes producing a documentation for it.

Don't be offended, but most of your work on PhpDoc is useless.
It seems that you are 10 years behind the times and live in the days of PHP 5.x

  • A simple example is this comit. You're trying to add a PhpDoc where you shouldn't.
  • I didn't see you really working on the documentation. Take a look at the history of the /docs folder and find your commits?
  • I haven't even seen you create useful issues...

@TheCartpenter
Copy link
Copy Markdown
Contributor Author

TheCartpenter commented Feb 22, 2025

I am focusing on finishing the PHPDocs to improve the quality of the platform while the core is being developed and maintained on this repository, since people are looking forward to have a stable version of the next release, and that includes producing a documentation for it.

Don't be offended, but most of your work on PhpDoc is useless. It seems that you are 10 years behind the times and live in the days of PHP 5.x

  • A simple example is this comit. You're trying to add a PhpDoc where you shouldn't.
  • I didn't see you really working on the documentation. Take a look at the history of the /docs folder and find your commits?

What you may have seen or not is none of my concern. What I do know is that I have worked several weeks on the PHPDocs since originally started to grow like that from the core by somebody else and the work was never finished and instead of getting positive feedback from the users, like you, you've simply brought chaos to my topics. I simply finished what was already started in order to get it done the way it was supposed to. You find that useless? Tell that to the original author who first introduced the idea. I got nothing to do with the way the idea started.

@batumibiz
Copy link
Copy Markdown
Contributor

I simply finished what was already started in order to get it done the way it was supposed to. You find that useless? Tell that to the original author who first introduced the idea. I got nothing to do with the way the idea started.

An idea can become obsolete, or change - this is not a dogma. The task that was set up a few years ago may no longer be needed today. Strong typing is now used everywhere, and in most places you can get rid of PhpDoc altogether. Or add when you really give a detailed description and instructions in it.

@TheCartpenter
Copy link
Copy Markdown
Contributor Author

I simply finished what was already started in order to get it done the way it was supposed to. You find that useless? Tell that to the original author who first introduced the idea. I got nothing to do with the way the idea started.

An idea can become obsolete, or change - this is not a dogma. The task that was set up a few years ago may no longer be needed today. Strong typing is now used everywhere, and in most places you can get rid of PhpDoc altogether. Or add when you really give a detailed description and instructions in it.

Well, that's not hard to figure that if you have suggestions to make to improve the platform where the core may require reverse changes to do so on the Discussions section of this repository, not on my topics since the changes that I keep proposing have nothing to do with getting rid of PHPDocs altogether - simple as that!

@batumibiz
Copy link
Copy Markdown
Contributor

Well, that's not hard to figure that if you have suggestions to make to improve the platform where the core may require reverse changes to do so on the Discussions section of this repository, not on my topics since the changes that I keep proposing have nothing to do with getting rid of PHPDocs altogether - simple as that!

What are you talking about?
I read it several times, but I still don't understand what you wanted to say?

@TheCartpenter
Copy link
Copy Markdown
Contributor Author

Well, that's not hard to figure that if you have suggestions to make to improve the platform where the core may require reverse changes to do so on the Discussions section of this repository, not on my topics since the changes that I keep proposing have nothing to do with getting rid of PHPDocs altogether - simple as that!

What are you talking about? I read it several times, but I still don't understand what you wanted to say?

Exactly. Which is why you keep posting by intoxicating this topic instead of leaving the contributors alone - because you "don't" understand the purpose of this project.

@batumibiz
Copy link
Copy Markdown
Contributor

Exactly. Which is why you keep posting by intoxicating this topic instead of leaving the contributors alone - because you "don't" understand the purpose of this project.

  1. You create discomfort by cluttering up the source code. As you can see, I'm not the only one complaining.
  2. Don't compare yourself to the project. We criticize you personally, not the OpenCart project.

@TheCartpenter
Copy link
Copy Markdown
Contributor Author

Exactly. Which is why you keep posting by intoxicating this topic instead of leaving the contributors alone - because you "don't" understand the purpose of this project.

  1. You create discomfort by cluttering up the source code. As you can see, I'm not the only one complaining.
  2. Don't compare yourself to the project. We criticize you personally, not the OpenCart project.

Wrong. I am critizized by others personally since the first post of this topic to post the PRs on one commit whereas the Github regulations does not dictate that from anywhere on the site as other people are not being critized doing the same thing. Therefore, what you are doing is admitting to offend a user discriminitively while I can't see anywhere on this repository where the same has been done to you regardless of what other people are complaining about. Therefore, you are not minding your own business as well as other people on the topic. Enough said!

@danielkerr danielkerr merged commit 2117635 into opencart:master Feb 23, 2025
0 of 4 checks passed
@TheCartpenter TheCartpenter deleted the patch-5 branch February 23, 2025 14:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants