Update editCategory#14501
Closed
mhcwebdesign wants to merge 1 commit intoopencart:masterfrom
mhcwebdesign:mhcwebdesign-patch-2
Closed
Update editCategory#14501mhcwebdesign wants to merge 1 commit intoopencart:masterfrom mhcwebdesign:mhcwebdesign-patch-2
mhcwebdesign wants to merge 1 commit intoopencart:masterfrom
mhcwebdesign:mhcwebdesign-patch-2
Conversation
When editing e.g. category 'Components' and then saving it, then all the SEO keywords from its sub-categories, such as 'Components > Mice and Trackballs', 'Components > Monitors', etc., are accidentally deleted. This bugfix restores the old editCategory function taken from OC 4.0.2.3 where this issue didn't exist.
Merged
Contributor
|
OC4.1 have no Looks like my solution does the same, but uses new OC4.1 model methods to collect the path and seo_url data instead of direct SQL queries. |
Contributor
Author
OC 4.1.0.0 does not have the 'top' field anymore in the 'oc_category', but there is still a 'column' field. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When editing e.g. category 'Components' and then saving it, then all the SEO keywords from its sub-categories, such as 'Components > Mice and Trackballs', 'Components > Monitors', etc., are accidentally deleted.
This bugfix restores the old editCategory function taken from OC 4.0.2.3 where this issue didn't exist.