Skip to content

[3.0.x.x] Add missing escape to filter moule#13698

Merged
danielkerr merged 1 commit intoopencart:3.0.x.xfrom
ADDCreative:patch-16
Feb 19, 2024
Merged

[3.0.x.x] Add missing escape to filter moule#13698
danielkerr merged 1 commit intoopencart:3.0.x.xfrom
ADDCreative:patch-16

Conversation

@ADDCreative
Copy link
Copy Markdown
Contributor

A possible safer way, given that third party themes are not likely to be updated, would be to change the controller to.

$data['action'] = str_replace('&', '&', $this->url->link('product/category', '&path=' . preg_replace('/[^0-9_]/', '', $this->request->get['path']) . preg_replace('/[^a-zA-Z0-9_\.&=]/', '', $url)));

@mhcwebdesign
Copy link
Copy Markdown
Contributor

I am not sure I understand. What issue exactly are you trying to fix here?

@danielkerr danielkerr merged commit 7d6fc2f into opencart:3.0.x.x Feb 19, 2024
@ADDCreative ADDCreative deleted the patch-16 branch February 20, 2024 09:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants