[3.0.x.x] Add cache control headers#13599
Merged
danielkerr merged 1 commit intoopencart:3.0.x.xfrom Feb 11, 2024
Merged
Conversation
Use header instead of $response->addHeader to prevent redirects being cached.
Contributor
|
I am not quite sure what issue exactly your are trying to resolve. The OC 4 master branch uses something like this: Wouldn't that work for the 3.0.x.x, too? |
Contributor
Author
|
Access-Control is something completely different to cache control. For the cache control, that is missing the Expires header which is needed in certain hosting configurations. Also, as I said, headers added with $response->addHeader don't get used on a redirect. So it was only really half fixed in 4.0.x. A better way would be to modify the response library to include headers on redirects and only set the headers when a session is started. For more information have a good read of #7008. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Still regular posts on the forum with issues cause by lack of cache control headers, which have never been added to 3.0.x.x.
Use header instead of $response->addHeader to prevent redirects being cached. Which can be a problem on hosting with an ExpiresDefault set. A better way would be to modify the response library to include headers on redirects and only send when a session is started.
Also probably needed to comply with data protection regulations.