[3.0.x.x]Update .php-cs-fixer.php#13581
Merged
mhcwebdesign merged 2 commits intoopencart:3.0.x.xfrom Jan 17, 2024
Merged
Conversation
Contributor
Author
|
@mhcwebdesign What you think? |
Contributor
|
OK, let's give it try. |
Contributor
|
It results in hundreds of warnings, and would required needed cosmetic code changes in almost every PHP file. This in turn would break loads of 3rd party extensions which use OCmod or VQmod. I think I am going to restore the previous .php-cs-fixer.php file. |
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I think this the best php-cs-fixer configuration for this branch, without changing array type...