Skip to content

[3.0.x.x] Include WeChat dependency#13556

Merged
danielkerr merged 1 commit intoopencart:3.0.x.xfrom
AJenbo:30-wechat
Jan 14, 2024
Merged

[3.0.x.x] Include WeChat dependency#13556
danielkerr merged 1 commit intoopencart:3.0.x.xfrom
AJenbo:30-wechat

Conversation

@AJenbo
Copy link
Copy Markdown
Contributor

@AJenbo AJenbo commented Jan 13, 2024

No description provided.

@AJenbo AJenbo requested a review from mhcwebdesign January 13, 2024 22:39
@danielkerr danielkerr merged commit 6f50845 into opencart:3.0.x.x Jan 14, 2024
@AJenbo AJenbo deleted the 30-wechat branch January 14, 2024 00:54
@mhcwebdesign
Copy link
Copy Markdown
Contributor

Please read my posted issue here: #13518

We should not use the abandoned vendor package 'zoujingli/wechat-php-sdk'!

Please undo this merge, and ask the wechatpay developer to update the payment extension, to use the recommended 'zoujingli/wechat-developer'. In the meantime we should remove this payment extension altogether.

Also, we need to make sure it supports all of the PHP versions 7.4 up to 8.3!

@mhcwebdesign
Copy link
Copy Markdown
Contributor

Having further tested it, it appears the old vendor package zoujingli/wechat-php-sdk doesn't support PHP 8.0 or later, it uses the deprecated PHP libxml_disable_entity_loader (see https://www.php.net/manual/en/function.libxml-disable-entity-loader.php).

If we keep the webchat_pay in there, then the least we should do is to restrict it to PHP versions < 8.0, which can be easily implemented in the catalog/model/extension/payment/wechat_pay.php and the admin/controller/extension/payment/wechat_pay.php .

Anyway, Daniel has now also asked his staff to contact the authors of wechat_pay, to see whether they can update it.

@AJenbo
Copy link
Copy Markdown
Contributor Author

AJenbo commented Jan 14, 2024

libxml_disable_entity_loader is only deprecated, and will likely continue to work until 9.0.

if oc treats it as a critical error you can supress it eith @

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants