[3.0.x.x] Include WeChat dependency#13556
Conversation
|
Please read my posted issue here: #13518 We should not use the abandoned vendor package 'zoujingli/wechat-php-sdk'! Please undo this merge, and ask the wechatpay developer to update the payment extension, to use the recommended 'zoujingli/wechat-developer'. In the meantime we should remove this payment extension altogether. Also, we need to make sure it supports all of the PHP versions 7.4 up to 8.3! |
|
Having further tested it, it appears the old vendor package zoujingli/wechat-php-sdk doesn't support PHP 8.0 or later, it uses the deprecated PHP libxml_disable_entity_loader (see https://www.php.net/manual/en/function.libxml-disable-entity-loader.php). If we keep the webchat_pay in there, then the least we should do is to restrict it to PHP versions < 8.0, which can be easily implemented in the catalog/model/extension/payment/wechat_pay.php and the admin/controller/extension/payment/wechat_pay.php . Anyway, Daniel has now also asked his staff to contact the authors of wechat_pay, to see whether they can update it. |
|
libxml_disable_entity_loader is only deprecated, and will likely continue to work until 9.0. if oc treats it as a critical error you can supress it eith @ |
No description provided.