Skip to content

[3.0.x.x] Hint classes loaded during framework bootup#13555

Merged
danielkerr merged 1 commit intoopencart:3.0.x.xfrom
AJenbo:30-bootup
Jan 14, 2024
Merged

[3.0.x.x] Hint classes loaded during framework bootup#13555
danielkerr merged 1 commit intoopencart:3.0.x.xfrom
AJenbo:30-bootup

Conversation

@AJenbo
Copy link
Copy Markdown
Contributor

@AJenbo AJenbo commented Jan 13, 2024

This lets PHPStan better reason about object relations in OC.

This works by using @mixinto document that the Controller, Model, and Proxy class has magic properties where for any none local will fetch them from the Registry, and there for allows calling it's properties directly on them.
And of cause document the classes that are commonly loaded into the registry during startup.

@AJenbo AJenbo requested a review from mhcwebdesign January 13, 2024 22:14
@AJenbo AJenbo changed the title Hint classes loaded during framework bootup [3.0.x.x] Hint classes loaded during framework bootup Jan 13, 2024
@danielkerr danielkerr merged commit 4a1bf39 into opencart:3.0.x.x Jan 14, 2024
@AJenbo AJenbo deleted the 30-bootup branch January 14, 2024 00:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants