Merged
Conversation
Contributor
Author
|
@mhcwebdesign It is correct? |
Contributor
|
Looks good to me. |
Contributor
|
Having said that, I don't think it will work, because of these lines: These config values don't exist anymore, we'd have to add a simple admin/controller/extension/payment/pp_express-recurring.php where it can be enabled and configured. But doesn't the PayPal Integration support recurring payments, too? |
Contributor
Author
|
I think Paypal Express supported recurring payments. |
Contributor
It probably did. I was just wondering whether the new PayPal Checkout Integration extension can support recurring payments, too. |
Contributor
|
This just needs removing. There is no PayPal express extension anymore to set the payment_pp_express_xxx configuration settings. So this will just do nothing. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.