Skip to content

Update pp_express.php#13505

Merged
mhcwebdesign merged 1 commit intoopencart:3.0.x.xfrom
condor2:patch-2
Jan 10, 2024
Merged

Update pp_express.php#13505
mhcwebdesign merged 1 commit intoopencart:3.0.x.xfrom
condor2:patch-2

Conversation

@condor2
Copy link
Copy Markdown
Contributor

@condor2 condor2 commented Jan 10, 2024

No description provided.

@condor2
Copy link
Copy Markdown
Contributor Author

condor2 commented Jan 10, 2024

@mhcwebdesign It is correct?

@mhcwebdesign mhcwebdesign merged commit ee63397 into opencart:3.0.x.x Jan 10, 2024
@mhcwebdesign
Copy link
Copy Markdown
Contributor

Looks good to me.

@mhcwebdesign
Copy link
Copy Markdown
Contributor

Having said that, I don't think it will work, because of these lines:

			if ($this->config->get('payment_pp_express_test')) {
				$api_url = 'https://api-3t.sandbox.paypal.com/nvp';
				$api_username = $this->config->get('payment_pp_express_sandbox_username');
				$api_password = $this->config->get('payment_pp_express_sandbox_password');
				$api_signature = $this->config->get('payment_pp_express_sandbox_signature');
			} else {
				$api_url = 'https://api-3t.paypal.com/nvp';
				$api_username = $this->config->get('payment_pp_express_username');
				$api_password = $this->config->get('payment_pp_express_password');
				$api_signature = $this->config->get('payment_pp_express_signature');
			}

These config values don't exist anymore, we'd have to add a simple admin/controller/extension/payment/pp_express-recurring.php where it can be enabled and configured.

But doesn't the PayPal Integration support recurring payments, too?

@condor2
Copy link
Copy Markdown
Contributor Author

condor2 commented Jan 10, 2024

I think Paypal Express supported recurring payments.

@condor2 condor2 deleted the patch-2 branch January 10, 2024 16:53
@mhcwebdesign
Copy link
Copy Markdown
Contributor

mhcwebdesign commented Jan 10, 2024

I think Paypal Express supported recurring payments.

It probably did. I was just wondering whether the new PayPal Checkout Integration extension can support recurring payments, too.

@ADDCreative
Copy link
Copy Markdown
Contributor

This just needs removing. There is no PayPal express extension anymore to set the payment_pp_express_xxx configuration settings. So this will just do nothing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants