Skip to content

[3.0.x.x] Update squareup.php#13487

Merged
mhcwebdesign merged 2 commits intoopencart:3.0.x.xfrom
condor2:patch-1
Jan 9, 2024
Merged

[3.0.x.x] Update squareup.php#13487
mhcwebdesign merged 2 commits intoopencart:3.0.x.xfrom
condor2:patch-1

Conversation

@condor2
Copy link
Copy Markdown
Contributor

@condor2 condor2 commented Jan 9, 2024

@mhcwebdesign
Copy link
Copy Markdown
Contributor

So has anyone actually tested the squareup payment method lately?

@mhcwebdesign mhcwebdesign merged commit 09039a6 into opencart:3.0.x.x Jan 9, 2024
@condor2 condor2 deleted the patch-1 branch January 9, 2024 16:27
@AJenbo
Copy link
Copy Markdown
Contributor

AJenbo commented Jan 10, 2024

@condor2 nice work looks like you are down to just 3 files with issues on level 0

@mhcwebdesign
Copy link
Copy Markdown
Contributor

@condor2 nice work looks like you are down to just 3 files with issues on level 0

Yes, but the remaining ones will be a bit more tricky.

For example, the WechatPay extension is quite old and not compatible with the newer current zoujingli vendor library. If I can't find a matching vendor library for the latter with support for all of the PHP 7.4 to 8.3 versions, then we might have to remove the WechatPay altogether.

@condor2
Copy link
Copy Markdown
Contributor Author

condor2 commented Jan 10, 2024

If it was up to me, I would delete almost all of them. 🤣

@AJenbo
Copy link
Copy Markdown
Contributor

AJenbo commented Jan 10, 2024

Once level 0 is solved should I try to setup reflection that allows further analysis and increase the level to 1?

Do we want that for the other forks like opencart_23xx and opencart-3?

On oc4 I'm slowly progressing on level 4 and level 6 is mostly done as well. The state of level 5 isn't clear to me yet but don't look impossible either.

@mhcwebdesign
Copy link
Copy Markdown
Contributor

Once level 0 is solved should I try to setup reflection that allows further analysis and increase the level to 1?

Do we want that for the other forks like opencart_23xx and opencart-3?

On oc4 I'm slowly progressing on level 4 and level 6 is mostly done as well. The state of level 5 isn't clear to me yet but don't look impossible either.

Let's first deal with the outstanding issues on OC 3.0.x.x before changing the analysis level. What does level 1 do?

@AJenbo
Copy link
Copy Markdown
Contributor

AJenbo commented Jan 10, 2024

Well that was exactly what I said we should.

Level one does the same type of checks as level 0, but for classes that utilizes magic methods and magic calls. Something that OC makes heavy use of inits proxy and registry so there are lots of areas that would not be checked by level 0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants