Skip to content

[3.0.x.x] Updated pgsql.php#13455

Merged
AJenbo merged 1 commit intoopencart:3.0.x.xfrom
condor2:patch-1
Jan 7, 2024
Merged

[3.0.x.x] Updated pgsql.php#13455
AJenbo merged 1 commit intoopencart:3.0.x.xfrom
condor2:patch-1

Conversation

@condor2
Copy link
Copy Markdown
Contributor

@condor2 condor2 commented Jan 7, 2024

@mhcwebdesign
Copy link
Copy Markdown
Contributor

Is anyone actually using PostgreSQL? Certainly for master branch and the opencart-3 repository it won't work and should be removed, especially after the many unneeded cosmetic changes to the various model classes.

@condor2
Copy link
Copy Markdown
Contributor Author

condor2 commented Jan 7, 2024

@mhcwebdesign Hmm..I don't know. Never used or tested :)
MySQLi is ok for me :)

@AJenbo
Copy link
Copy Markdown
Contributor

AJenbo commented Jan 7, 2024

@mhcwebdesign by cosmetic changes are you referring the addition of backticks to the sql statements?

https://wiki.postgresql.org/wiki/Things_to_find_out_about_when_moving_from_MySQL_to_PostgreSQL

I do agree that this has probably broken the queries on most databases that are not MySQL variants, and should probably be revered.

Or are there other things you think would also cause issues?

@mhcwebdesign
Copy link
Copy Markdown
Contributor

@mhcwebdesign by cosmetic changes are you referring the addition of backticks to the sql statements?

https://wiki.postgresql.org/wiki/Things_to_find_out_about_when_moving_from_MySQL_to_PostgreSQL

I do agree that this has probably broken the queries on most databases that are not MySQL variants, and should probably be revered.

Or are there other things you think would also cause issues?

Yes, it's mostly about the backticks. As far as I know, no intensive testing for PostgreSQL was ever done .

@AJenbo
Copy link
Copy Markdown
Contributor

AJenbo commented Jan 7, 2024

As far as I know, no intensive testing for PostgreSQL was ever done

Looks more like zero testing was done, the queries are completely broken for PostgreSQL. Most appears to have been done here: 3f71794

This means that since OC 4.0 PostgreSQL has been completely broken. The same is also true for opencart-3. But so is 3.0.x.x: 6239803. It looks like the only working option for someone on PostgreSQL would be Opencart_23xx

Edit: Looks like Daniel is even somewhat aware of the issue: #12121 (comment)

@condor2
Copy link
Copy Markdown
Contributor Author

condor2 commented Jan 7, 2024

@AJenbo If you refer to backward escaped. I have added also on my repo....

@AJenbo
Copy link
Copy Markdown
Contributor

AJenbo commented Jan 7, 2024

Ok, then I guess that OC on PostgreSQL is just dead.

@AJenbo AJenbo merged commit e27ba19 into opencart:3.0.x.x Jan 7, 2024
@condor2 condor2 deleted the patch-1 branch January 7, 2024 17:11
@mhcwebdesign
Copy link
Copy Markdown
Contributor

That's why I suggested a while ago to remove the system/library/db/pgsql.php altogether, see #12869

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants