[3.0.x.x] Remove Ref check from proxy.php#13426
Merged
danielkerr merged 1 commit into3.0.x.xfrom Jan 6, 2024
Merged
Conversation
Contributor
|
I tend to agree, just checked all the previous OpenCart versions for a getRef function or a Ref class, can't find one anywhere. Maybe Daniel can shed some light here on this? |
Contributor
Author
|
Yeah the history for this project is rather hard to navigate. |
Contributor
Author
|
@mhcwebdesign just 47 issues left, gl |
Contributor
I am going to look into the remaining issues reported by PHPStan this coming week, most of them appear to come from the various payment extensions. Some of the latter appear to be quite old or obsolete, I already removed some of them because of using obsolete or abandoned 3rd party APIs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refdoes not exist (and it doesn't appear it ever did) so checking for it is pointless.The check was originally added here: 248bf46
Then got changed to
Referencein OC4, with comments about being broken from other devs:bca8e10
Referencethen got added here: fe0b691Then fully removed here: c705bc4