Closed
Conversation
Contributor
Author
|
@danielkerr Could you please provide a comment explaining the reason for the closure? You merged #12896 which fixes other PHP 7.4 syntax issues so it's hard to understand what you felt was wrong about this one. |
Member
|
i already acceoted ur other commit. i thought they were the same |
Contributor
Author
|
... they didn't exist before you closed this one |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I hear the code is suppose to be 7.4 compatible so here are some fixes for that to be true.
See #12896 for one issue not addressed by this PR.