Remove dead code from getTotalProductsByProductId#12899
Merged
danielkerr merged 1 commit intoopencart:masterfrom Nov 10, 2023
Merged
Remove dead code from getTotalProductsByProductId#12899danielkerr merged 1 commit intoopencart:masterfrom
danielkerr merged 1 commit intoopencart:masterfrom
Conversation
Member
|
its used in best sellers |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As there is no way to feed the $data array to the function this code can never be activated. Also it does not look to have been and omission as the call site has no trace of filter variables that would fit here.
The offending code was introduced in this commit which also does not appear to have intended for it usage: e49531f