Skip to content

Update dashboard.php#12824

Merged
danielkerr merged 1 commit intoopencart:masterfrom
TheCartpenter:patch-1330
Nov 2, 2023
Merged

Update dashboard.php#12824
danielkerr merged 1 commit intoopencart:masterfrom
TheCartpenter:patch-1330

Conversation

@TheCartpenter
Copy link
Copy Markdown
Contributor

No description provided.

@batumibiz
Copy link
Copy Markdown
Contributor

In order to add one space, did you create a separate PR?

@TheCartpenter
Copy link
Copy Markdown
Contributor Author

In order to add one space, did you create a separate PR?

Not required to add a separate PR. Once the code changed has been merged to the project, all we really need is the sync button from our forked repositories to ensure the changes are up-to-date.

@mhcwebdesign
Copy link
Copy Markdown
Contributor

In order to add one space, did you create a separate PR?

He refuses to use a proper Git client, making life miserable for all the other developers/contributors.

@TheCartpenter
Copy link
Copy Markdown
Contributor Author

In order to add one space, did you create a separate PR?

He refuses to use a proper Git client, making life miserable for all the other developers/contributors.

#12843 (comment)

@batumibiz
Copy link
Copy Markdown
Contributor

batumibiz commented Oct 31, 2023

He refuses to use a proper Git client, making life miserable for all the other developers/contributors.

@mhcwebdesign It seems to me that he does not use any GIT client at all and edits the code through the WEB interface from the browser. GitHub WEB interface has exactly this behavior: for each individual file when saved, it creates a separate PR.
We need to create a collective complaint to Daniel, otherwise this disgrace will not stop.

@danielkerr danielkerr merged commit 9a3b31a into opencart:master Nov 2, 2023
@TheCartpenter TheCartpenter deleted the patch-1330 branch December 9, 2023 17:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants