empty instruction on the default extensions causes a bad time#12502
Merged
danielkerr merged 1 commit intoopencart:masterfrom Jul 22, 2023
Merged
empty instruction on the default extensions causes a bad time#12502danielkerr merged 1 commit intoopencart:masterfrom
danielkerr merged 1 commit intoopencart:masterfrom
Conversation
With an empty description, the extension parser has a bad time with the json and never loads. There needs to be another update to the ocmod as well, but I'm not sure what the policy is for outsiders proposing changes on zip files.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With an empty instruction, the extension parser has a bad time with the install.json and never loads. There needs to be another update to the opencart.ocmod as well, but I'm not sure what the policy is for outsiders proposing changes on zip files. When trying to upload the opencart.ocmod.zip, the error_install message is returned (Warning: Could not find install.json)