Change page location on admin product filter#12402
Merged
danielkerr merged 1 commit intoopencart:masterfrom Jul 2, 2023
stalker780:patch-1
Merged
Change page location on admin product filter#12402danielkerr merged 1 commit intoopencart:masterfrom stalker780:patch-1
danielkerr merged 1 commit intoopencart:masterfrom
stalker780:patch-1
Conversation
The new AJAX filter breaks page location and browser behavior. If you refresh a page or click browser Back button you will loose current product filter. pushState changes current location address and adds it to browser history. This should be done for all filtered admin lists like products, reviews, customers, customer approvals, seo urls, orders
This was referenced Jul 2, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The new AJAX filter breaks page location and browser behavior.
If you refresh a page or click browser Back button you will loose current product filter.
pushState changes current location address and adds it to browser history.
This should be done for all filtered admin lists like products, reviews, customers, customer approvals, seo urls, orders