Merged
Conversation
`$option_data` is created two times but it is not used. Also in the first creation of `$option_data`, The uploaded file name is correctly added to array, But second time that the variable is created the file name is replaced: Currently it is something like this in the shopping cart: Apple Cinema 30" - Radio: Small - File: e9b62648b8dee13f9e26e76557cf8ade It should be: Apple Cinema 30" - Radio: Small - File: image.png
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
$option_datais created two times but it is not used in the final array$product_data.Also in the first creation of
$option_data, The uploaded file name is correctly added to array, But second time that the variable is created the file name is replaced.Currently it is something like this in the shopping cart:
Apple Cinema 30"
It should be:
Apple Cinema 30"