Skip to content

Create apcu#12288

Merged
danielkerr merged 7 commits intoopencart:masterfrom
BuslikDrev:patch-2
Jul 4, 2023
Merged

Create apcu#12288
danielkerr merged 7 commits intoopencart:masterfrom
BuslikDrev:patch-2

Conversation

@BuslikDrev
Copy link
Copy Markdown
Contributor

@BuslikDrev BuslikDrev commented Apr 23, 2023 •
edited
Loading

@danielkerr
Copy link
Copy Markdown
Member

danielkerr commented Jul 4, 2023

we already have apc

@danielkerr danielkerr merged commit b8cd8be into opencart:master Jul 4, 2023
danielkerr added a commit that referenced this pull request Jul 4, 2023
@danielkerr
https://github.com/opencart/opencart/pull/12288
ede7f99
@ADDCreative
Copy link
Copy Markdown
Contributor

ADDCreative commented Jul 4, 2023

Doesn't look like it supports using just a * wildcard, such as the one in the backup restore.

opencart/upload/admin/controller/tool/backup.php

Line 307 in 4ccac08

$this->cache->delete('*');

File cache would have the same issue as the fix #9739 never made it to the master branch.

@danielkerr
Copy link
Copy Markdown
Member

danielkerr commented Jul 4, 2023

Yes so don't use it.

@ADDCreative
Copy link
Copy Markdown
Contributor

ADDCreative commented Jul 5, 2023

@danielkerr Which to use then, even the default file cache won't support:

opencart/upload/admin/controller/tool/backup.php

Line 307 in 4ccac08

$this->cache->delete('*');

opencart/upload/system/library/cache/file.php

Lines 57 to 60 in 4db9933

public function delete(string $key): void {
$files = glob(DIR_CACHE . 'cache.' . preg_replace('/[^A-Z0-9\._-]/i', '', $key) . '.*');
if ($files) {

@BuslikDrev BuslikDrev deleted the patch-2 branch July 31, 2023 17:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@BuslikDrev @danielkerr @ADDCreative