need leading space to prevent appending to link#12223
need leading space to prevent appending to link#12223danielkerr merged 1 commit intoopencart:3.0.x.x_Maintenancefrom
Conversation
Without a leading space before "the" the word "The" ends up getting appended to the reset link resulting in users clicking on it and getting an "invalid reset link" message.
|
I don't believe this isn't a fix for anything. There is no need for a space there There is clearly whitespace in the template already. I suspect @daretogo is using a version of PHP that is not compatible with the version of Twig they are using. https://forum.opencart.com/viewtopic.php?t=210652#p803802 |
|
@ADDCreative: Some older versions of twig, as used in e.g. OpenCart 3.0.2.0, couldn't handle whitespaces correctly, as documented at https://twig.symfony.com/doc/3.x/templates.html#whitespace-control However, this shouldn't be an issue with the 3.0.x.x_Maintenance branch because that one uses the latest version 3.6.1 of Symfony Twig. Personally I use the alternative OpenTwig engine (www.opentwig.org) on my client's websites. |
|
@mhcwebdesign That was the exact point I was making. No need for this change in the 3.0.x.x_Maintenance branch. |
Without a leading space before "the" the word "The" ends up getting appended to the reset link resulting in users clicking on it and getting an "invalid reset link" message.