Fix passed by reference warning in PHP 8#10836
Merged
mhcwebdesign merged 1 commit intoopencart:3.0.x.x_Maintenancefrom May 9, 2022
Merged
Fix passed by reference warning in PHP 8#10836mhcwebdesign merged 1 commit intoopencart:3.0.x.x_Maintenancefrom
mhcwebdesign merged 1 commit intoopencart:3.0.x.x_Maintenancefrom
Conversation
Contributor
|
Thanks. Have you also tested it with the admin/model/extension/advertise/google.php (see function setAdvertisingBySelect at line 295) ? Just to be sure before the merge. |
Contributor
Author
|
Didn't test, but did look the code for setAdvertisingBySelect and setAdvertisingByFilter. Nothing was passed by reference and integer() does not modify the value, so there is no need for integer() to require a reference. |
Contributor
|
OK, now merged. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For #10358.