Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: openbootdotdev/openboot
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: v0.60.1
Choose a base ref
...
head repository: openbootdotdev/openboot
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: v0.60.2
Choose a head ref
  • 1 commit
  • 3 files changed
  • 2 contributors

Commits on Jun 2, 2026

  1. fix: clone external zsh plugins referenced by dotfiles .zshrc (#122) 

    * fix: clone external zsh plugins referenced by dotfiles .zshrc

When a remote config carries no shell block (rc.Shell == nil) but does set a
dotfiles_repo, the shell setup comes entirely from the stowed .zshrc. Its
plugins=() list — e.g. zsh-autosuggestions, fast-syntax-highlighting,
zsh-autocomplete — never flowed through RestoreFromSnapshot, so the external
plugins it names were never git-cloned into $ZSH_CUSTOM/plugins. oh-my-zsh
then logged "plugin '...' not found" on every shell startup.

Add shell.CloneExternalPluginsFromZshrc: after dotfiles are linked, read the
effective ~/.zshrc, extract plugins=(), and clone any catalog (external)
plugins not already present. Built-in/unknown names are left untouched and a
failed clone stays non-fatal, matching cloneExternalPlugins. No-op when
oh-my-zsh isn't installed or .zshrc is absent, and dry-run safe.

This is the path `openboot install <slug>` takes for configs like
fullstackjam, where #121's plan-level fix could not help because there was no
shell block to carry through.

* fix: guard plugin name against path traversal before clone

gosec G703 flagged cloneExternalPlugins now that plugin names can originate
from a user-authored .zshrc (via CloneExternalPluginsFromZshrc) and flow into
filepath.Join. Add an explicit path-segment guard rejecting names that aren't
a plain single segment, and annotate the os.Stat with a justified nolint. A
name only reaches here after matching the curated catalog, so this guard only
ever rejects malicious input — it's defense in depth, not a behavior change.

* fix: treat unreadable .zshrc as non-fatal in plugin clone

An unreadable .zshrc now warns and returns nil instead of aborting the
dotfiles step. By the time CloneExternalPluginsFromZshrc runs the dotfiles
are already cloned and linked, and plugin setup is best-effort everywhere
else (cloneExternalPlugins warns and continues on a failed clone), so a
marginal read error should not fail the whole step. Add a test covering the
non-NotExist read-error path.

---------

Co-authored-by: Claude <noreply@anthropic.com>
    @fullstackjam @claude
    fullstackjam and claude authored Jun 2, 2026
    Configuration menu
    Copy the full SHA
    92f4e4e View commit details
    Browse the repository at this point in the history
Loading