Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: openbootdotdev/openboot
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: v0.58.12
Choose a base ref
...
head repository: openbootdotdev/openboot
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: v0.58.13
Choose a head ref
  • 1 commit
  • 18 files changed
  • 1 contributor

Commits on May 25, 2026

  1. fix: address code review findings across installer, auth, and brew (#105 

    )

* fix: address code review findings across installer, auth, and brew

- installer: remove four dead step* functions (stepMacOS, stepPostInstall,
  stepShell, stepDotfiles, hasDotfiles) that had no production callers;
  tests in installer_test.go were exercising this dead code instead of the
  live apply* paths, producing false coverage
- installer: replace 14 TestStep* and 5 TestHasDotfiles* tests with
  equivalent tests on the real apply* functions and Plan() entrypoints
- auth: pollOnce now uses httputil.Do() instead of httpClient.Get(),
  consistent with startAuthSession(); HTTP 429 + Retry-After handling
  now applies to poll requests; archtest baseline updated
- brew: InstallWithProgress now returns a non-nil error when packages
  permanently fail after retries (was silently swallowing failures)
- brew: ctx context.Context threaded through InstallWithProgress and all
  internal brew helpers; exec.CommandContext used so installs are
  cancellable
- brew: retryBrew() helper extracted to deduplicate the retry-with-backoff
  loop shared by installFormulaWithError and installSmartCaskWithError
- brew: parseBrewError default line truncation increased from 60 to 120
  chars to preserve enough error context
- brew: PreInstallChecks(formulaeCount, caskCount int) uses type-aware
  estimates (0.1 GB/formula, 0.5 GB/cask) instead of a flat 0.2 GB/pkg
- archtest baselines regenerated to reflect removed dead code and shifted
  line numbers

* chore: apply gofmt formatting to installer files
    @fullstackjam
    fullstackjam authored May 25, 2026
    Configuration menu
    Copy the full SHA
    9950ddd View commit details
    Browse the repository at this point in the history
Loading