Dockerfile: upgrade to go 1.12.10 and reduce layer churn around packages#986
Dockerfile: upgrade to go 1.12.10 and reduce layer churn around packages#986
Conversation
so, I did that superfluous
WDYT? |
|
Hey @shlomi-noach! I figured it was done on purpose, here's why I think doing it the current way is better for the average case, and for the long term:
Ultimately, I think combining everything to reduce layers matches the Docker best practices, optimizes for the common case of building a release asset and not a development tool, and produces the easiest to read, digest and work with Dockerfile, as it follows the accepted Docker best practices, which result in a smaller and more efficient image. |
That makes perfect sense. Thank you! |
Description
This PR offers some improvements to the bundled Dockerfile for
orchestrator, namely:apkto avoid superflous calls to their registry, as well as the creation of extra layersI did not create an issue as this is a proactive PR - I am happy to do any needed work, but I opted to move to a PR due to security constrains around the bump of Go versioning.
gofmt(please avoidgoimports)./build.shgo test ./go/...