This repository was archived by the owner on Feb 18, 2025. It is now read-only.
MySQLOrchestratorSSLSkipVerify to apply on backend TLS config#985
Merged
shlomi-noach merged 7 commits intomasterfrom Nov 13, 2019
Merged
MySQLOrchestratorSSLSkipVerify to apply on backend TLS config#985shlomi-noach merged 7 commits intomasterfrom
shlomi-noach merged 7 commits intomasterfrom
Conversation
Collaborator
Author
|
cc @ggunson for visibility |
Collaborator
|
Code looks good. Going to double check it works here, so should be able to give you some feedback shortly. |
Collaborator
Author
|
@sjmudd any thoughts per chance? |
Collaborator
Author
|
I'm merging this PR given some constraints. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes what seems to be a bug: when certificate can be skipped (
MySQLOrchestratorSSLSkipVerify = true) the existing code still demanded to add X509 key pair.With this PR, when
MySQLOrchestratorSSLSkipVerify = trueand when no certificate files exist, then we don't attempt to load them.Another logic seems to have been flawed in
SetupMySQLTopologyTLS: again, certificates were required whenMySQLTopologySSLSkipVerify = true.The new logic is as follows: