This repository was archived by the owner on Feb 18, 2025. It is now read-only.
Merged
Conversation
added 30 commits
December 25, 2016 14:40
Collaborator
Author
|
This branch, and its predecessor This PR includes rehaul of indexes on all tables. Users of |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is one-step-down from #63 ; it's all the same: full support for
sqlitebackend, along with schema changes, query changes. However in this PRsqlutils.godoesn't actuallyimport _ "github.com/mattn/go-sqlite3.(Do notesqlite3is included invendor/in this PR)sqlite3removed fromvendor/until I figure out what's the best way to incorporate it (maybe just binary? Future PR to tell)Reason is still ongoing thoughts about the compilation process.
sqlite3is heavyweight to compile. Whilego build -idoes the job reasonably well, there is a once-in-a-while long compilation time. I'll be looking into usingsqlite3as.soshared file viago1.7.So in this PR everything supports sqlite, but
sqliteis not strictly included and is effectively disabled.