This repository was archived by the owner on Feb 18, 2025. It is now read-only.
support searching by cluster alias#936
Merged
shlomi-noach merged 3 commits intoopenark:masterfrom Aug 6, 2019
Merged
Conversation
Collaborator
|
Thank you! Since this is a web UI enhancement, can you please paste screenshots for "before" and "after" this change? |
shlomi-noach
approved these changes
Aug 1, 2019
Collaborator
shlomi-noach
left a comment
There was a problem hiding this comment.
Looks good! I made a code suggestion that I think should go in. Looking forward to screenshots.
apply review notes Co-Authored-By: Shlomi Noach <shlomi-noach@github.com>
Contributor
Author
|
Hello Shlomi, |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related issue: #935
Description:
Support for search using cluster alias. Show cluster alias instead of cluster name in search results UI if it is set