This repository was archived by the owner on Feb 18, 2025. It is now read-only.
optional systemd-based build packaging#915
Merged
shlomi-noach merged 13 commits intomasterfrom Jun 26, 2019
Merged
Conversation
Collaborator
Author
|
Gonna merge this as-is. With this PR (again, contributed by @mateusduboli), one would: or |
Collaborator
Author
|
fat fingers. A followup PR will dockerize the build process to generate both options. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A resubmission of #653 by @mateusduboli (for irrelevant technical reasons), but in this PR we still use the
rootuser; while agreed this is not ideal, I'm concerned with backwards compatibility -- how users who already assume therootusers would be impacted if they install a newer package which uses a different account. So pushing that decision till later.cc @sjmudd