This repository was archived by the owner on Feb 18, 2025. It is now read-only.
Merged
Conversation
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
At master failover:
On successful promotion, immediately update
database_instanceand replace oldcluster_namewith newcluster_name. This does not change any logic in the failover, merely speeds up the discovery/resolution of the cluster's instances as part of the new cluster.Push post failover hooks till after
MasterFailoverDetachReplicaMasterHost,ReplaceClusterNameandSetGeneralAttribute, all of which are immediate or near-immediate operations.A future PR will run more concurrent operations.