This repository was archived by the owner on Feb 18, 2025. It is now read-only.
Suggested fix for https://github.com/github/orchestrator/issues/901#903
Merged
shlomi-noach merged 1 commit intoopenark:masterfrom May 30, 2019
Merged
Suggested fix for https://github.com/github/orchestrator/issues/901#903shlomi-noach merged 1 commit intoopenark:masterfrom
shlomi-noach merged 1 commit intoopenark:masterfrom
Conversation
shlomi-noach
approved these changes
May 30, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Details are in: #901
This tiny patch allows for the "instance" to be defined automatically via
/etc/profile.d/orchestrator-client.shso thatorchestrator-clientcan behave more like theorchestratorbinary and not require the-i <instance>parameter to be used every time.I added a minor description in the script to explain usage and reason for the addition.