This repository was archived by the owner on Feb 18, 2025. It is now read-only.
Adding Region; Prevent cross region failover#884
Merged
shlomi-noach merged 5 commits intomasterfrom May 16, 2019
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adding Region field in Instance, and a corresponding
regioncolumn indatabase_instancebackend table.Region is a geographic location, of higher level than DataCenter. E.g. an AWS
us-east-1is a region.The region value is supported by the following new configuration variables:
RegionPattern: a regexp to extract the region name from the hostname, if possibleDetectRegionQuery: alternatively, a query which computes the regionPreventCrossRegionMasterFailover: a failover restriction which only allows failovers within same region as failed master, or else abort promotion of a new master (similar in behavior toPreventCrossDataCenterMasterFailover)