This repository was archived by the owner on Feb 18, 2025. It is now read-only.
NoFailoverSupportStructureWarning, NoLoggingReplicasStructureWarning#852
Merged
shlomi-noach merged 5 commits intomasterfrom Apr 2, 2019
Merged
NoFailoverSupportStructureWarning, NoLoggingReplicasStructureWarning#852shlomi-noach merged 5 commits intomasterfrom
shlomi-noach merged 5 commits intomasterfrom
Conversation
added 2 commits
March 28, 2019 13:01
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #837
This PR introduces:
NoLoggingReplicasStructureWarning: if the master has> 1replicas, and none has binary logs +log_slave_updates(which means none can take over its siblings upon failover)NoFailoverSupportStructureWarning: if there's no Oracle-GTID, MariaDB-GTID, Pseudo-GTID, binlog-server setup, and more than 1 replica:orchestratorhas no reliable failover plan.(related: Failover recovery, graceful takeover don't work w/binlog #824)