Skip to content
This repository was archived by the owner on Feb 18, 2025. It is now read-only.

Modify bulk-promotion-rules api call to return the promotion rule expiry timestamp#843

Merged
shlomi-noach merged 3 commits intoopenark:masterfrom
sjmudd:smudd/promotion_rule_expiry
Mar 24, 2019
Merged

Modify bulk-promotion-rules api call to return the promotion rule expiry timestamp#843
shlomi-noach merged 3 commits intoopenark:masterfrom
sjmudd:smudd/promotion_rule_expiry

Conversation

@sjmudd
Copy link
Collaborator

@sjmudd sjmudd commented Mar 19, 2019

Description

See: #842 bulk promotion rule information does not include expiry information.

This PR [briefly explain what is does]

  • contributed code is using same conventions as original code
  • code is formatted via gofmt (please avoid goimports)
  • code is built via ./build.sh

Copy link
Collaborator

@shlomi-noach shlomi-noach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shlomi-noach shlomi-noach temporarily deployed to production/mysql_cluster=concertmaster March 19, 2019 11:04 Inactive
@shlomi-noach shlomi-noach temporarily deployed to production/mysql_cluster=concertmaster March 19, 2019 12:25 Inactive
@shlomi-noach shlomi-noach temporarily deployed to production/mysql_cluster=concertmaster March 24, 2019 07:05 Inactive
@shlomi-noach shlomi-noach merged commit 2c818cb into openark:master Mar 24, 2019
@sjmudd sjmudd deleted the smudd/promotion_rule_expiry branch December 25, 2021 20:16
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants