This repository was archived by the owner on Feb 18, 2025. It is now read-only.
Add the DiscoveryIgnoreReplicaHostnameFilters in the sample configuration.#815
Merged
shlomi-noach merged 2 commits intoopenark:masterfrom Mar 2, 2019
jfg956:master
Merged
Add the DiscoveryIgnoreReplicaHostnameFilters in the sample configuration.#815shlomi-noach merged 2 commits intoopenark:masterfrom jfg956:master
shlomi-noach merged 2 commits intoopenark:masterfrom
jfg956:master
Conversation
shlomi-noach
suggested changes
Feb 25, 2019
Collaborator
shlomi-noach
left a comment
There was a problem hiding this comment.
@jfg956 thank you! It's noteworthy that the value is actually a regular expression. A fixed hostname would work, but so will .*[.]datacenter3[.]example[.]com. Perhaps we should also provide a regexp as example?
Author
|
@shlomi-noach: I made explicit that DiscoveryIgnoreReplicaHostnameFilters can be a regexp. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add the DiscoveryIgnoreReplicaHostnameFilters in the sample configuration.
A Pull Request should be associated with an Issue.
#814
Description
Add the DiscoveryIgnoreReplicaHostnameFilters in the sample configuration.