This repository was archived by the owner on Feb 18, 2025. It is now read-only.
orchestrator-client gsed support for Darwin/BSD#795
Merged
shlomi-noach merged 6 commits intoopenark:masterfrom Mar 24, 2019
Merged
orchestrator-client gsed support for Darwin/BSD#795shlomi-noach merged 6 commits intoopenark:masterfrom
shlomi-noach merged 6 commits intoopenark:masterfrom
Conversation
Collaborator
shlomi-noach
left a comment
There was a problem hiding this comment.
Is Darwin guaranteed to have gsed installed?
Contributor
Author
|
It unfortunately is not, most people have it installed out of the |
Merged
Collaborator
|
This caused an infinite loop of |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related issue: #794
Description
This PR adds in some logic in
orchestrator-clientto switch over togsedif the system isn't guaranteed to have GNU coreutils installed.