This repository was archived by the owner on Feb 18, 2025. It is now read-only.
ChangeMasterCredentials: fixed when server is not a replica#789
Merged
shlomi-noach merged 2 commits intomasterfrom Feb 7, 2019
Merged
ChangeMasterCredentials: fixed when server is not a replica#789shlomi-noach merged 2 commits intomasterfrom
shlomi-noach merged 2 commits intomasterfrom
Conversation
|
@shlomi-noach, thank you for quick response. |
Collaborator
Author
|
whoops. committed an unrelated change. |
Collaborator
Author
|
@pasha167 please test again now |
|
Yes, that works 👍. Thanks. |
Collaborator
Author
|
This PR also introduces a concurrency cap on the number of replicas operated on |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #788
This fixes the
ChangeMasterCredentials()behavior on masters. Behavior was broken by #767cc @pasha167