This repository was archived by the owner on Feb 18, 2025. It is now read-only.
fix flappy integration test#785
Merged
shlomi-noach merged 5 commits intoopenark:masterfrom Jan 28, 2019
Merged
Conversation
Small maps (of 2 items) are randomized badly, i.e. their keys has the same order *almost* always, but not always. This leads to rare test failures in commands that depends on keys order, such as untag (untag-all-03)
4 tasks
Collaborator
shlomi-noach
left a comment
There was a problem hiding this comment.
Thank you. I wonder if this shouldn't be the other way around: that the tests sort the results, and we keep randomized iteration in GetInstanceKeys(). I don't feel strongly either way.
Contributor
Author
|
If you don't rely on any particular order of GetInstanceKeys(), then this patch breaks nothing. If you do rely on alphabetic order of GetInstanceKeys() (as it looks like in |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Small maps (of 2 items) are randomized badly,
i.e. their keys has the same order almost always, but not always.
This leads to rare test failures in commands that depends on keys order,
such as untag (untag-all-03)
A Pull Request should be associated with an Issue.
Related issue: https://github.com/github/orchestrator/issues/0123456789
Description
This PR [briefly explain what is does]
gofmt(please avoidgoimports)./build.shgo test ./go/...