This repository was archived by the owner on Feb 18, 2025. It is now read-only.
Handle MariaDB behavior of dropping relay log entries on failure scenarios#1374
Merged
shlomi-noach merged 5 commits intomasterfrom Jun 30, 2021
Merged
Handle MariaDB behavior of dropping relay log entries on failure scenarios#1374shlomi-noach merged 5 commits intomasterfrom
shlomi-noach merged 5 commits intomasterfrom
Conversation
…arios Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1363
IO_THREADon MariaDBThe two changes together solve the issue of losing relay log entries in MariaDB on failover. The loss of entries (MariaDB specific behavior, explained in #1260 (comment)) causes prootion to proceed even if
DelayMasterPromotionIfSQLThreadNotUpToDateis enabled.