This repository was archived by the owner on Feb 18, 2025. It is now read-only.
ReasonableInstanceCheckSeconds#1368
Merged
shlomi-noach merged 1 commit intoopenark:masterfrom Jun 16, 2021
Merged
Conversation
shlomi-noach
approved these changes
Jun 16, 2021
Collaborator
shlomi-noach
left a comment
There was a problem hiding this comment.
Looks good, thank you!
Contributor
Author
|
For reference, if this ever needs to be tested, you can test it by setting This will make the check take 5 seconds, so with the normal config it'll fail. If you then set it should work again |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related issue: #1367
This PR introduces a config option
ReasonableInstanceCheckSecondsthat allows configuring the time that Orchestrator allows for a check to take before considering an instanced failed (LastCheckValid: false). Currently this value is hardcoded as 1s.More details in the issue.