This repository was archived by the owner on Feb 18, 2025. It is now read-only.
Introducing RecoverReadOnlyMaster option, ReadOnlyMaster failure analysis and recovery#1330
Closed
shlomi-noach wants to merge 3 commits intomasterfrom
Closed
Introducing RecoverReadOnlyMaster option, ReadOnlyMaster failure analysis and recovery#1330shlomi-noach wants to merge 3 commits intomasterfrom
shlomi-noach wants to merge 3 commits intomasterfrom
Conversation
…ysis and recovery Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
Collaborator
Author
|
I wonder if we should just use |
…tion treating it as error Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
Collaborator
Author
|
Closed in favor of #1332 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1328
Description
This PR introduces an opt-in behavior: when a replication cluster's primary is found to be
read_only,orchestratoranalyzes that as a failure scenario and, based on opt-in configuration, spawn a recovery.This behavior is controlled by the new variable
RecoverReadOnlyMaster(defaultsfalse)